Skip to content

Fix admin 404 incorrectly falling back to standalone design - #92

Merged
CrazyBoy49z merged 2 commits into
mainfrom
fix/admin-404-shell-regardless-auth
Oct 10, 2026
Merged

CrazyBoy49z merged 2 commits into
mainfrom
fix/admin-404-shell-regardless-auth

Conversation

@CrazyBoy49z

Copy link
Copy Markdown
Member

Root cause

The full admin error layout was gated behind Auth::guard(...)->check(). Unknown admin URLs have no matching route middleware, so authentication state can be unavailable even for a browser that is signed in, causing the standalone error page shown in the screenshot.

Fix

  • Always attempt real Lazy Admin layout for 404, independent of the authentication check.
  • Preserve authorization-dependent behavior for 403 and lightweight errors for 401/419/429/500/503.
  • Catch failure while rendering the full admin shell and fall back to the standalone page, preserving HTTP 404 instead of escalating the failure.
  • Update tests; fix malformed test class namespace escaping.

Single commit. CI / visual verification needed before merging.

@CrazyBoy49z
CrazyBoy49z merged commit 26c60e6 into main Oct 10, 2026
1 check passed
@CrazyBoy49z
CrazyBoy49z deleted the fix/admin-404-shell-regardless-auth branch October 10, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant